Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scan): 'for await' support in script setup for dev server #3889

Merged
merged 1 commit into from
Jun 23, 2021
Merged

fix(scan): 'for await' support in script setup for dev server #3889

merged 1 commit into from
Jun 23, 2021

Conversation

trebler
Copy link
Contributor

@trebler trebler commented Jun 21, 2021

Description

Fixes issue mentioned in #2528 (comment). Specifically, when using script setup and having for await loops (non-TLA), the dev server fails to start, e.g.:

<script lang="ts" setup>
// type Subscription = AsyncIterable<{value: number}>;
const readSubscription = async (subscription: Subscription): Promise<void> => {
    for await (const { value } of subscription) {
       //
    }
};

readSubscription(subscription).catch(() => {});
> yarn dev
> html:...: error: Expected "(" but found "void"
    for void (const { value } of subscription) {

This PR removes workaround that was replacing most awaits with voids in script setup.

Additional context

The workaround introduced in 24ed098 to tackle esbuild not supporting TLA (#2044) in no longer (evanw/esbuild#253 (comment)) relevant.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sodatea sodatea added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 23, 2021
@patak-dev patak-dev changed the title fix(scan): dev server fails to start when having 'for await' loop (non-TLA) in script setup fix(scan): 'for await' support in script setup for dev server Jun 23, 2021
@patak-dev patak-dev merged commit dd46cd1 into vitejs:main Jun 23, 2021
@trebler trebler deleted the fix-for-await-script-setup-dev branch June 24, 2021 00:17
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants