Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-react): transform .mjs files #5314

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix(plugin-react): transform .mjs files #5314

merged 1 commit into from
Oct 15, 2021

Conversation

aleclarson
Copy link
Member

.mjs files were not being transformed by @vitejs/plugin-react

@aleclarson aleclarson added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 15, 2021
@patak-dev
Copy link
Member

Why should we transform .mjs and not .js. Is there a .mjsx equivalent to .jsx?

@aleclarson
Copy link
Member Author

Why should we transform .mjs and not .js.

We transform both if you look a little closer :)

Is there a .mjsx equivalent to .jsx?

Nope

@patak-dev patak-dev merged commit 8ce2ea1 into vitejs:main Oct 15, 2021
@aleclarson aleclarson deleted the fix/react-mjs branch February 25, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleclarson @patak-dev