Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use enhanced-resolve instead of resolve #5593

Closed
wants to merge 1 commit into from
Closed

fix: use enhanced-resolve instead of resolve #5593

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Nov 8, 2021 •
edited
Loading

Description

Fixes #3953

resolve doesn't support ESM resolution: browserify/resolve#222

Would not be necessary if #3951 is merged

Additional context

SvelteKit's libraries cannot be externalized without this change

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann force-pushed the raythurnevoid-enhanced-resolve branch from 186fd5d to 2ca540e Compare November 8, 2021 23:49
@benmccann benmccann mentioned this pull request Nov 8, 2021
Closed
6 tasks
@Bandit Bandit mentioned this pull request Nov 9, 2021
Open
@benmccann benmccann force-pushed the raythurnevoid-enhanced-resolve branch from 2ca540e to 13e7fa3 Compare November 10, 2021 04:04
@robertsLando robertsLando mentioned this pull request Nov 10, 2021
Closed
@benmccann
Copy link
Collaborator Author

Closing since #3951 was merged

@benmccann benmccann closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite doesn't support ESM packages with "exports" field in SSR
1 participant
@benmccann