fix: externals bug in vite ssr, promote noExternal as first priority

[zhangyuang]

Description

Now, vite ssr external judge condition is not exact.
For example, vite will set default dependencies to ssr.externals, but easy to evaluated failed when someone use ui library like antd/vant

import { Button } from 'vant'

ssr.externals will be ['vant'].

But in general, these code will be written like

import { Button } from 'vant'
import 'vant/es/lib/button/style/index.js'

and style/index.js import css/less type file

$ cat node_modules/vant/es/button/style/index.js
import '../../style/base.css';
import '../../badge/index.css';
import '../../icon/index.css';
import '../../loading/index.css';
import '../index.css';%

The expected behavior is vant will be external but vant/es/lib/button/style/index.js cannot be externals need transformed, even if i set ssr.noExternal like

ssr: {
    external: ['vant'],
    noExternal: [/vant.*?style/]
 }

can't take effect because the judge condition is not exact.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[zhangyuang]

OK，i will modify it 发自我的iPhone

…

------------------ Original ------------------ From: Ben McCann ***@***.***> Date: Thu,Jan 6,2022 10:31 PM To: vitejs/vite ***@***.***> Cc: yuuang ***@***.***>, Author ***@***.***> Subject: Re: [vitejs/vite] fix: externals bug in vite ssr, promote noExternalas first priority (PR #6023) @benmccann commented on this pull request. In packages/vite/src/node/ssr/ssrExternal.ts: > ): boolean { + const noExternalsArr: RegExp[] = + noExternals !== true + ? (Array.isArray(noExternals) ? noExternals : [noExternals]).map( + (item) => { + if (typeof item === 'string') { + item = new RegExp(item) I don't think you can just convert strings to regexes like this. The strings are meant to be exact matches. If the user wants to provide a regex they can simply pass that to begin with — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: ***@***.***>

[benmccann]

At a high level, I'm not sure why there's two copies of the logic to use external / noExternal. It seems like the root cause of this issue is that shouldExternalizeForSSR and resolveSSRExternal are not in sync. It seems like resolveSSRExternal should use shouldExternalizeForSSR or that the result of resolveSSRExternal should be cached and we remove shouldExternalizeForSSR

[zhangyuang]

At a high level, I'm not sure why there's two copies of the logic to use external / noExternal. It seems like the root cause of this issue is that shouldExternalizeForSSR and resolveSSRExternal are not in sync. It seems like resolveSSRExternal should use shouldExternalizeForSSR or that the result of resolveSSRExternal should be cached and we remove shouldExternalizeForSSR

resolveSSRExternal use rollup.createFilter to generate externals but it's not exactly when external and noExternal has partial intersection