Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): ignore babel config when running babel-restore-jsx (fixes #5082) #6047

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

arbassett
Copy link
Contributor

Description

fix #5082

@vitejs/plugin-react restore-jsx babel plugin was loading user babel configs (.babelrc & babel.config.js). if the user config contained @babel/preset-react it could cause an Maximum call stack size exceeded error in large react files

Additional context

while i was unable to create a minimal reproducible example for Maximum call stack size exceeded i was able to show the babel config being improperly loaded https://stackblitz.com/edit/vitejs-vite-f6dptj?devtoolsheight=33&file=babel.config.js


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@aleclarson aleclarson added the p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Dec 12, 2021
@patak-dev patak-dev merged commit 9c2843c into vitejs:main Dec 12, 2021
@arbassett arbassett deleted the fix/restore-jsx-ignore-user-babel branch December 12, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react plugin: Maximum call stack size exceeded
4 participants