Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delegate error handling to express’s error handler #6611

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Jan 24, 2022

Description

This PR updates the SSR example code to pass errors to Express.js’s error handler through the next argument, instead of handling it directly from the endpoint, for more idiomatic Express code.

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

@import-brain you said you have express knowledge, could you review that?

@Niputi Niputi added the documentation Improvements or additions to documentation label Jan 24, 2022
Copy link

@import-brain import-brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patak-dev patak-dev merged commit 6b6ad70 into vitejs:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants