feat(client): support "full-reload" event with any page path #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other words, stop requiring a .html extension for a selective page reload, because that prevents certain pages from being selectively reloaded. For example, if I send a "full-reload" event with a `path` of "/foo.html", it will not reload clients whose location is "/foo". Similarly, sending a full-reload event with a path of "/foo/index.html" will not reload "/foo" clients either. In this case, only clients at "/foo/" will be reloaded. Therefore, we should allow sending a full-reload event with a path of "/foo" to specifically target clients at "/foo".
|
Closing as changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words, stop requiring a
.htmlextension for a selective page reload, because that prevents certain pages from being selectively reloaded.For example, if I send a
"full-reload"event with apathof"/foo.html", it will not reload clients whose location is"/foo". Similarly, sending a full-reload event with a path of"/foo/index.html"will not reload"/foo"clients either. In this case, only clients at"/foo/"will be reloaded.Therefore, we should allow sending a
full-reloadevent with a path of"/foo"to specifically target clients at"/foo".What is the purpose of this pull request?