Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(legacy): note works in build only #7596

merged 1 commit into from Apr 3, 2022


Copy link

@bluwy bluwy commented Apr 3, 2022


Closes #6577

Additional context

Also removed the Vite peer dep note. It now technically requires ^2.8.0, but I think the peer dep requirement in package.json should suffice.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the documentation Improvements or additions to documentation label Apr 3, 2022
@patak-dev patak-dev merged commit f26b14a into vitejs:main Apr 3, 2022
@bluwy bluwy deleted the docs-legacy-readme branch April 4, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
documentation Improvements or additions to documentation
None yet

Successfully merging this pull request may close these issues.

@vitejs/plugin-legacy doesn't work on ie11, the script isn't executed and it isn't transpiled.
2 participants