Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-vite): use Type assertion in preact-ts #8579

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

jsdayuan
Copy link
Contributor

Description

Convert preact-ts of template Non-null assertion to Type assertion, remain the same as template react-ts

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title chore(create-vite): preact-ts Non-null assertion -> Type assertion chore(create-vite): use Type assertion in preact-ts Jun 14, 2022
@patak-dev patak-dev merged commit d1ba059 into vitejs:main Jun 14, 2022
winderica added a commit to winderica/vite that referenced this pull request Jun 14, 2022
winderica added a commit to winderica/vite that referenced this pull request Jun 14, 2022
winderica added a commit to winderica/vite that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants