Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimizeDeps.entries transformRequest url (fix #8719) #8748

merged 1 commit into from Jun 24, 2022


Copy link


Fix #8719 repro brillout/vite-3-bug_hmr-first-dev

The optimizeDeps.entries were not normalized, and in #8719 an entry which is the same entry the app starts with was included, leading to it being processing twice in parallel (instead of being deduplicated by the pendingRequests logic)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 68747cf
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev added p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) feat: hmr feat: deps optimizer Esbuild Dependencies Optimization labels Jun 23, 2022
@patak-dev patak-dev added this to the 3.0 milestone Jun 23, 2022
@patak-dev patak-dev merged commit 9208c3b into main Jun 24, 2022
@patak-dev patak-dev deleted the fix/optimize-deps-entries-url branch June 24, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: deps optimizer Esbuild Dependencies Optimization feat: hmr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

[Vite 3] HMR doesn't work on first dev
2 participants