-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve extension of css assets in the manifest #8768
fix: preserve extension of css assets in the manifest #8768
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
@jessarcher @innocenzi Would you check if this commit is desirable or not? Not sure how the Laravel plugins are using |
If I understood correctly what pure CSS chunks are, LGTM 👍 I use |
@ElMassimo This looks great, thanks! I've tested it out with both The official Laravel plugin isn't actually using |
Thanks for the feature review and quick fix @ElMassimo! |
Since vitejs/vite#8768 Vite will now add style assets to the manifest preserving the original extension.
Description
Fixes #8764 by preserving the original extension for CSS asset entry names in the manifest.
It also preserves
isEntry
information for CSS asset chunks, which is useful for backend integrations.Additional context
#6649 added assets to the manifest, but the entries are invalid for Sass/Less/Stylus stylesheets, as it's erasing the original extension from the manifest entry names and src.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).