Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle context resolve options #8966

merged 2 commits into from Jul 7, 2022


Copy link

@bluwy bluwy commented Jul 7, 2022


Ensure this.resolve is compatible with Rollup, passing custom and isEntry options too.

Additional context

This is needed to fix sveltejs/kit#5387 (comment). I'll send a subsequent PR to fix that issue after this is merged.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6daca97
🔍 Latest deploy log

@patak-dev patak-dev merged commit 57c6c15 into vitejs:main Jul 7, 2022
@bluwy bluwy deleted the fix-plugin-container-resolve-custom branch July 7, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Can't build SvelteKit component libraries with "moduleResolution": "NodeNext"
2 participants