Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scan): handle .ts import as .js alias #9282

Merged
merged 2 commits into from Jul 21, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 21, 2022

Description

fix #9198

Additional context

I thought I captured this before, but it wasn't accurate as /@/ doesn't match the /^[\w@][^:]/ filter, @/ does because it looks package-ish. However, the scanner is handling fine for this, just that we also need to pass the ts heuristic into it.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Jul 21, 2022
@patak-dev patak-dev merged commit 0b083ca into main Jul 21, 2022
12 checks passed
@patak-dev patak-dev deleted the fix-vue-scan-alias branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias and node next module resolution results in dep scan error of a typescript file import in a vue SFC
2 participants