Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiline dynamic imports #9314

Merged
merged 5 commits into from Jul 23, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 23, 2022

Description

Fix #8918

The in-code comments should explain why this is needed.

Additional context

I haven't gotten around setting up es-module-lexer locally, and navigating a fix, so this may do for now 馃槵


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 馃敤 An edge case that only affects very specific usage (priority) label Jul 23, 2022
@patak-dev patak-dev merged commit e66cf69 into vitejs:main Jul 23, 2022
12 checks passed
@bluwy bluwy deleted the fix-dynamic-import-vars-multiline branch Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 馃敤 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3] Failed to parse source for import analysis when dynamic import has comment
2 participants