Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use same external rule as rollup for esbuild (fix #9549) #9552

Closed

Conversation

zhyupe
Copy link

@zhyupe zhyupe commented Aug 5, 2022

Description

Fix #9549
If a-module is external, do not treat a-module/file as external during optimizeDep.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy
Copy link
Member

bluwy commented Nov 28, 2022

This would break a fair amount of apps so we probably couldn't do this in Vite 4. Since this is related to esbuild optimization in build which is still experimental, we probably want to find a non-breaking way to support this if possible.

@zhyupe zhyupe closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error on esbuild deps optimization with imports to cjs files inside externalized module
2 participants