fix: module graph ensureEntryFromUrl based on id #9759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we check for a module existence via url in
ensureEntryForUrl
, but a url could map to the same resolved id that already exists inidToModulesMap
(e.g. via a different url that also resolves to the same id).This can currently happen for two URLs like:
This PR changes to check the resolved id instead, and update the url to use the existing id & module if possible.
Additional context
Ref withastro/astro#4378
Feels related to #9730 and #7845
Something similar has been happening in SvelteKit too
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).