Fix horizontal scroll bug #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this does hide the "x" button until the .title element is made wide enough, but I think that is better than the scroll bar. |
manzt
approved these changes
May 5, 2020
keller-mark
added a commit
that referenced
this pull request
May 5, 2020
* Change rectangle selection to dragging (#520) * Update to new raster schema and add multi-image demo (#515) * Add Material UI Icons * Change `Channels` component to `LayerController` * Use raster schema v0.0.1 * Migrate to functional subscribers and allow for multiple layers * Reduce size of PubSub `LAYER_CHANGE` events * Memoize derived data in Subscribers * Change Linnarsson static layout * Add a higlass component (#523) * Initial higlass commit * Update styles, use onReady function * Update (#482) * Change height calculation * Changelog * Lazy load higlass component * Lint * Minor update * Merge * Clean up higlass integration, update styles, move higlass viewconfig into vitessce viewconfig * Whitespace * Styles * Comments * Remove bootstrap * Remove more bootstrap * Update src/components/higlass/HiGlassSubscriber.js Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com> * Lint * Clean up css * Clean up css again * Remove weird line height value * Figure out react.lazy Co-authored-by: Sehi L'Yi <sehi_lyi@hms.harvard.edu> Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com> * 0.1.1 * Revert "0.1.1" This reverts commit 88eb6a0. * Clear rectangle or lasso selection on click (#530) * Handle clicks during rectangle and lasso * Use constants for edit types rather than strings/nulls * viv 0.2.2 (#531) * Upgrade viv to 0.2.2 * Changelog * Changelog version * 0.1.1 * Changelog * Changelog * Fix horizontal scroll bug (#534) * Fix horizontal scroll bug * Changelog * Update CHANGELOG.md Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com> Co-authored-by: Sehi L'Yi <sehi_lyi@hms.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In manual testing of the latest demo, I realized that the "33 genes" subtitle of the Expression Levels box now overflows and produces an ugly horizontal scrollbar (at least on smaller screens). I had fixed this in the metadata tables commit here but now that we are waiting to merge that, I had to make a separate one-line fix in a this PR.