-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql parser errors #69
Comments
Hi gadumitrachioaiei, If you're trying to reuse the parser for something else, you should be able to fork and add the necessary constructs. PS: Among your suggested constructs, you could easily convince me to extend our grammar to support ANY (and SOME). |
@sougou Not allowing joins has been a (great) design goal of of vitess, AFAIR. Is this design goal still valid? |
I'm not sure why you think joins are bad. Can you clarify? |
Thanks for the explanations. I had the intention of using vitess only for parsing sql queries. |
* 1.合并分支 * 1.测试用例 IN * 1.roll back set WOffset * 1.fix bind error 2.fix order by 1
… 2 (vitessio#69) * Skip recalculating the rate in MaxReplicationLagModule when it can't be done This defends against lag records with nil stats which can lead to segfaults. See vitessio#12619 Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Add support for criticality query directive, and have TxThrottler respect that Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Remove unused variable Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix CI pipeline Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy & add extra test cases. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix circular import Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments: * Invalid criticality in query directive fails the query. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix executor.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix go/vt/vtgate/executor.go again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix TestNewMaxReplicationLagModule_recalculateRate * Fix go/vt/vtgate/executor_test.go * Regen protos from linux Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
I have tried the sqlparser library and I get parsing errors on a few sql queries. Some examples:
DELETE FROM term_hierarchy AS th WHERE th.parent = 1015
Error at position 30: as
SELECT s1 FROM t1 WHERE s1 = ANY (SELECT s1 FROM t2)
Error at position 41: select
DELETE FROM t1, t2 USING t1 INNER JOIN t2 INNER JOIN t3 WHERE t1.id=t2.id AND t2.id=t3.id
Error at position 16: ,
The text was updated successfully, but these errors were encountered: