Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlparser: Handle case sensitive AST option for table options #10191

Merged
merged 1 commit into from
May 3, 2022
Merged

sqlparser: Handle case sensitive AST option for table options #10191

merged 1 commit into from
May 3, 2022

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented May 2, 2022 •
edited by deepthi
Loading

In case of a CREATE TABLE statement, the options are rendered directly and the TableOptions logic is not used. This means it doesn't handle character set or collation options like an ALTER TABLE does.

This updates the logic to be consistent with column level settings and with ALTER TABLE.

Related Issue(s)

Part of extension work after #9719

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@dbussink dbussink requested review from vmg and shlomi-noach May 2, 2022 20:43
@dbussink
sqlparser: Handle case sensitive AST option for table options
81fd4b3 
In case of a `CREATE TABLE` statement, the options are rendered directly
and the TableOptions logic is not used. This means it doesn't handle
character set or collation options like an `ALTER TABLE` does.

This updates the logic to be consistent with column level settings and
with `ALTER TABLE`.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the handle-table-options-consistently branch from 6ba2ae2 to 81fd4b3 Compare May 2, 2022 20:44
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022 •
edited by dbussink
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

vmg
vmg approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy! Thanks for fixing this!

@vmg vmg merged commit f08ba5b into main May 3, 2022
@vmg vmg deleted the handle-table-options-consistently branch May 3, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @vmg @shlomi-noach