Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of unsigned and zerofill in parser and normalization #10220

Merged

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented May 5, 2022

In the parser when generating a query, unsigned and zerofill are always rendered lowercase in canonical MySQL output.

Additionally, zerofill is deprecated for integer values similar to the length. Zerofill does still have a side effect though which is that it also does mark the field as unsigned.

The normalization now removes the zerofill attribute, but sets unsigned to true if it was used to keep this side effect.

Also see https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html for the reference documentation on how this works.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

In the parser when generating a query, unsigned and zerofill are always
rendered lowercase in canonical MySQL output.

Additionally, zerofill is deprecated for integer values similar to the
length. Zerofill does still have a side effect though which is that it
also does mark the field as unsigned.

The normalization now removes the zerofill attribute, but sets unsigned
to true if it was used to keep this side effect.

Also see
https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html for
the reference documentation on how this works.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@vmg vmg merged commit 01eab00 into vitessio:main May 5, 2022
@vmg vmg deleted the dbussink/fix-unsigned-and-zerofill-handling branch May 5, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants