Fix handling of unsigned and zerofill in parser and normalization #10220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the parser when generating a query, unsigned and zerofill are always rendered lowercase in canonical MySQL output.
Additionally, zerofill is deprecated for integer values similar to the length. Zerofill does still have a side effect though which is that it also does mark the field as unsigned.
The normalization now removes the zerofill attribute, but sets unsigned to true if it was used to keep this side effect.
Also see https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html for the reference documentation on how this works.
Related Issue(s)
Checklist