Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: RangeRotationDistinctStatements partitioning hint #10309

Conversation

shlomi-noach
Copy link
Contributor

Description

Follow up to #10234. We change behavior as follows:

  • The flag RangeRotationStatements is renamed to RangeRotationDistinctStatements to better describe what it does (as of this PR)
  • When two tables are diffed, and partition rotation hint is RangeRotationDistinctStatements, and there are indeed partition rotation changes, then the result is a sequence of diffs (one diff with linked subsequent diffs). If the table definition it self was also diffed (e.g. a modified column), that is allowed, and that will always be the primary diff, to which the partition diffs are appended. If the table is otherwise unmodified, then the primary diff is the first in partition changes.
  • As reminder, when RangeRotationStrategy is RangeRotationFullSpec, the above is irrelevant, and the diff results with a single ALTER TABLE, that may include a full partitioning spec.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes none labels May 15, 2022
@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how allowing this functionality is mostly removing code 😄.

@shlomi-noach shlomi-noach merged commit 3891d40 into vitessio:main May 15, 2022
@shlomi-noach shlomi-noach deleted the schemadiff-partitioning-distinct-queries branch May 15, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants