Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop_foreign_keys to v2 MoveTables command #10773

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add drop_foreign_keys to v2 MoveTables command #10773

merged 1 commit into from
Jul 21, 2022

Conversation

dbussink
Copy link
Contributor

Description

This change was missed in #9904 so it doesn't work for v2 right now.

Related Issue(s)

#9904 which missed this change

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

This also will need to be backported to 14 then which is missing this bit as well.

add drop_foreign_keys to v2 MoveTables command
162f974 
Signed-off-by: Phani Raj <phani@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 21, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

rohit-nayak-ps
rohit-nayak-ps approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 1b88e7d into vitessio:main Jul 21, 2022
@vitess-bot vitess-bot bot mentioned this pull request Jul 21, 2022
Merged
@deepthi
Copy link
Member

deepthi commented Jul 21, 2022

Thank you @dbussink!

rsajwani pushed a commit to planetscale/vitess that referenced this pull request Aug 1, 2022
@rohit-nayak-ps @dbussink
add drop_foreign_keys to v2 MoveTables command (vitessio#10773) (vite…
3bdc65b 
…ssio#852)

Signed-off-by: Phani Raj <phani@planetscale.com>

Co-authored-by: Phani Raj <phani@planetscale.com>

Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Phani Raj <phani@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @deepthi @rohit-nayak-ps