Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reset transaction session when no reserved connection #12779

Merged

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 30, 2023

Description

This PR fixes a bug exposed on PRS when the settings pool is enabled on vttablet.
A transaction leaves the tablet tagged to the shard session even after a commit or rollback.

On PRS, that session will keep sending the query to the same tablet and would receive the error until that session is closed and new session is created.
vttablet: rpc error: code = FailedPrecondition desc = wrong tablet type: PRIMARY, want: REPLICA or []", state: "HY000"

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported 16.0 and main
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal harshit-gangal added Forwardport to: main This will forward port the PR to the main branch Backport to: release-16.0 labels Mar 30, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 30, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 30, 2023
@harshit-gangal harshit-gangal marked this pull request as ready for review March 30, 2023 10:51
…nnection

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 8b301a2 into vitessio:release-15.0 Mar 31, 2023
@harshit-gangal harshit-gangal deleted the fix-tx-session-reset branch March 31, 2023 10:53
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 31, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 31, 2023

I was unable to forwardport this Pull Request to the following branches: main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Forwardport to: main This will forward port the PR to the main branch Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants