-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: reset transaction session when no reserved connection #12779
Merged
harshit-gangal
merged 2 commits into
vitessio:release-15.0
from
planetscale:fix-tx-session-reset
Mar 31, 2023
Merged
Fix: reset transaction session when no reserved connection #12779
harshit-gangal
merged 2 commits into
vitessio:release-15.0
from
planetscale:fix-tx-session-reset
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit-gangal
added
Forwardport to: main
This will forward port the PR to the main branch
Backport to: release-16.0
labels
Mar 30, 2023
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Mar 30, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Mar 30, 2023
harshit-gangal
force-pushed
the
fix-tx-session-reset
branch
from
March 30, 2023 10:50
77e59e0
to
7c6561d
Compare
harshit-gangal
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
systay and
deepthi
as code owners
March 30, 2023 10:51
systay
approved these changes
Mar 30, 2023
frouioui
approved these changes
Mar 30, 2023
…nnection Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
fix-tx-session-reset
branch
from
March 31, 2023 06:08
7c6561d
to
ae2f6bd
Compare
GuptaManan100
approved these changes
Mar 31, 2023
I was unable to backport this Pull Request to the following branches: |
I was unable to forwardport this Pull Request to the following branches: |
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Forwardport to: main
This will forward port the PR to the main branch
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug exposed on PRS when the settings pool is enabled on vttablet.
A transaction leaves the tablet tagged to the shard session even after a commit or rollback.
On PRS, that session will keep sending the query to the same tablet and would receive the error until that session is closed and new session is created.
vttablet: rpc error: code = FailedPrecondition desc = wrong tablet type: PRIMARY, want: REPLICA or []", state: "HY000"
Related Issue(s)
Checklist
Deployment Notes