-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rowcache deprecation #1742
Rowcache deprecation #1742
Conversation
This is the first step of deprecating rowcache. We just remove the command line flags for now. In the next steps we'll start deleting code and associated tests.
Bunch of code has been deleted. Binaries build, but not tests.
tabletserver unit tests done
All unit tests are passing. Some cleanup still needed in planbuilder.
planbuilder and parser simplifcations
All done (I think). This final change simplifies the planbuilder.
|
Reviewed 73 of 73 files at r1. examples/kubernetes/vttablet-pod-benchmarking-template.yaml, line 77 [r1] (raw file):
This breaks the config because you removed the trailing Comments from Reviewable |
These are no longer needed after vitessio#1742.
@alainjobart @enisoc
Turning off the flags was trivial, which is the first change. But then, what's the long weekend for. I went ahead and deleted all the rowcache code also. Some areas needed refactoring.
This change is