Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rowcache deprecation #1742

Merged
merged 6 commits into from
May 31, 2016
Merged

Rowcache deprecation #1742

merged 6 commits into from
May 31, 2016

Conversation

sougou
Copy link
Contributor

@sougou sougou commented May 31, 2016

@alainjobart @enisoc
Turning off the flags was trivial, which is the first change. But then, what's the long weekend for. I went ahead and deleted all the rowcache code also. Some areas needed refactoring.


This change is Reviewable

This is the first step of deprecating rowcache. We just
remove the command line flags for now. In the next steps
we'll start deleting code and associated tests.
Bunch of code has been deleted. Binaries build, but
not tests.
tabletserver unit tests done
All unit tests are passing. Some cleanup still needed
in planbuilder.
planbuilder and parser simplifcations
All done (I think). This final change simplifies the planbuilder.
@alainjobart
Copy link
Contributor

alainjobart commented May 31, 2016

:lgtm: good stuff :)

Previously, sougou wrote…

Rowcache deprecation

@alainjobart @enisoc

Turning off the flags was trivial, which is the first change. But then, what's the long weekend for. I went ahead and deleted all the rowcache code also. Some areas needed refactoring.


Reviewed 73 of 73 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

Approved with PullApprove

@sougou sougou merged commit 25542cd into vitessio:master May 31, 2016
@enisoc
Copy link
Member

enisoc commented May 31, 2016

Reviewed 73 of 73 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


examples/kubernetes/vttablet-pod-benchmarking-template.yaml, line 77 [r1] (raw file):

          -enable_replication_reporter
          -rowcache-bin /usr/bin/memcached
          -rowcache-socket $VTDATAROOT/{{tablet_subdir}}/memcache.sock" vitess

This breaks the config because you removed the trailing " vitess. I'm going to remove memcached from the Docker images, so I'll fix this along with that.


Comments from Reviewable

enisoc added a commit to enisoc/vitess that referenced this pull request May 31, 2016
These are no longer needed after vitessio#1742.
@sougou sougou deleted the rowcache branch June 13, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants