Limiting random MySQL server ids to 2^31-1. #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-berlin
approved these changes
Nov 22, 2016
| // that implies is a full 32 bits number, and the code that encodes or | ||
| // decodes serverIDs from core mysqld, which uses signed int32. | ||
| // Such an ID may also be responsible for a mysqld crash in semi-sync code, | ||
| // although we haven't been able to verify that yet. |
There was a problem hiding this comment.
Can you please add the link to the GitHub issue here?
| // - It avoids the 2^31 - 2^32-1 range, as there seems to be some confusion | ||
| // between the documentation at: | ||
| // http://dev.mysql.com/doc/refman/5.7/en/replication-options.html | ||
| // that implies is a full 32 bits number, and the code that encodes or |
There was a problem hiding this comment.
"that implies is a full ..."
nit: A word before "is" is missing?
enisoc
reviewed
Nov 22, 2016
| // between the documentation at: | ||
| // http://dev.mysql.com/doc/refman/5.7/en/replication-options.html | ||
| // that implies serverID is a full 32 bits number, and the code that encodes or | ||
| // decodes serverIDs from core mysqld, which uses signed int32. |
There was a problem hiding this comment.
I haven't seen any evidence that code in core mysqld uses signed int32. The problem I observed was that the semi-sync plugin appears to use signed int32.
alainjobart
force-pushed
the
serverid
branch
from
87db199
to
9030d35
Compare
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2280