Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrepl: use <keyspace.workflow> #5456

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Nov 24, 2019

Since a workflow belongs to only one keyspace, we can simplify
command line arguments to use the <keyspace.workflow> notation.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

Since a workflow belongs to only one keyspace, we can simplify
command line arguments to use the <keyspace.workflow> notation.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested a review from deepthi November 24, 2019 04:18
go/vt/vtctl/vtctl.go Show resolved Hide resolved
go/vt/vtctl/vtctl.go Show resolved Hide resolved
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can merge once Travis passes.

@sougou sougou merged commit 7983603 into vitessio:master Nov 24, 2019
@sougou sougou deleted the ss-vrepl-workflow-name branch November 24, 2019 05:44
systay pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants