Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of plan building #7054

Merged
merged 11 commits into from
Nov 23, 2020
Merged

Refactoring of plan building #7054

merged 11 commits into from
Nov 23, 2020

Commits on Nov 17, 2020

  1. Refactored First and PushMisc 

    Introduce Inputs and Rewrite as a way to visit all nodes in the tree,
and used them to implement First and PushMisc outside the builders

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    c7d3bd7 View commit details
    Browse the repository at this point in the history

  2. Extracted SetUpperLimit from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    3ae36f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. extracted PushLock from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    4b824c0 View commit details
    Browse the repository at this point in the history

  2. extracted PushFilter from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    354ec9a View commit details
    Browse the repository at this point in the history

  3. extracted PushSelect from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    ae3798e View commit details
    Browse the repository at this point in the history

  4. extracted PushGroupBy from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    6b0916e View commit details
    Browse the repository at this point in the history

  5. extracted MakeDistinct() from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    2ff2c72 View commit details
    Browse the repository at this point in the history

  6. extracted PushOrderBy from the builder interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a2d35c8 View commit details
    Browse the repository at this point in the history

  7. renamed builder to logicalPlan 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    93d8023 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. make sure to support distinct and grouping in the same query 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    03ef581 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. removed unused code 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    42099a2 View commit details
    Browse the repository at this point in the history