Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for the TabletManager GetSchema RPC #9658

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 9, 2022

Description

While working on something else (which will be closed, see here for why), I was surprised to see that we have 0 tests (unit or e2e) for the TabletManager's GetSchema RPC call.

It is tested indirectly through MoveTables and Reshard workflow related tests.

This PR adds a dedicated e2e test for it.

Related Issue(s)

Checklist

  • Should this PR be backported? NO
  • Tests were added
  • Documentation is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 573a22b into vitessio:main Feb 9, 2022
@rohit-nayak-ps rohit-nayak-ps deleted the getschema_test branch February 9, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants