Online DDL: managed online schema changed via gh-ost and pt-online-schema-change #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
|
Deploy preview for vitess ready! Built with commit 71ffb7e |
…nctionality Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…rue' supplied Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
force-pushed
the
online-ddl
branch
from
a4345bf
to
6f2156a
Compare
|
ping. Request for review 🙏 |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…ction Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
deepthi
reviewed
Oct 6, 2020
content/en/docs/user-guides/schema-changes/managed-online-schema-changes.md
Outdated
Show resolved
Hide resolved
content/en/docs/user-guides/schema-changes/managed-online-schema-changes.md
Outdated
Show resolved
Hide resolved
content/en/docs/user-guides/schema-changes/managed-online-schema-changes.md
Outdated
Show resolved
Hide resolved
content/en/docs/user-guides/schema-changes/managed-online-schema-changes.md
Outdated
Show resolved
Hide resolved
content/en/docs/user-guides/schema-changes/managed-online-schema-changes.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
@deepthi fixed all requested changes. |
|
LGTM but I'd like to wait for a review from @bnlandry |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
ping @bnlandry may we have your kind review 🙏 ? |
deepthi
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting changes in vitessio/vitess#6547
Should only merge once vitessio/vitess#6547 is merged.