Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support accessing task from test context without accessing fixtures #4419

Merged

Conversation

dsyddall
Copy link
Contributor

@dsyddall dsyddall commented Nov 1, 2023

Description

Fixes #4418

Currently, when extending a test function with fixtures, if the fixtures are unused within a given test or hook, when accessing non-fixture context (e.g. task) the test fails with an error:
TypeError: Cannot destructure property 'isFn' of 'fixture' as it is undefined.

Example:

const myTest = test.extend({ a: 1 })

myTest('accessing non-fixture context', ({ task }) => {
  expect(task).toBeTruthy()
})

This PR addresses the above error by making withFixtures return early if the pendingFixtures array is empty after having been filtered.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

stackblitz bot commented Nov 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit f184ad2
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/654204349bdfcb000815671f

@dsyddall dsyddall force-pushed the fix-access-only-non-fixture-context branch from d5faef5 to f184ad2 Compare November 1, 2023 07:54
@sheremet-va sheremet-va merged commit 3397fdc into vitest-dev:main Nov 2, 2023
16 checks passed
@dsyddall dsyddall deleted the fix-access-only-non-fixture-context branch November 2, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixture "task" is not available anymore
3 participants