Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary (?) check for if vite is installed #4656

Closed
6 tasks done
wojtekmaj opened this issue Dec 4, 2023 · 0 comments · Fixed by #4659
Closed
6 tasks done

Unnecessary (?) check for if vite is installed #4656

wojtekmaj opened this issue Dec 4, 2023 · 0 comments · Fixed by #4659

Comments

@wojtekmaj
Copy link
Contributor

Describe the bug

I'm currently facing a blocker (#4655) from upgrading vitest to 1.0. However, I'm struggling to understand why the check for whether vite is installed is even there? vite is declared directly in vitest dependency so there's no physical way vite would ever be missing, and the whole check is just slowing things down. Am I wrong?

Reproduction

  • Install vitest using Yarn PnP
  • Run vitest

System Info

System:
    OS: macOS 14.1.1
    CPU: (8) arm64 Apple M2
    Memory: 32.31 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - /private/var/folders/3y/swkjq1x101b76mzjgt4pm2d80000gp/T/xfs-2ac5acc4/node
    Yarn: 4.0.2 - /private/var/folders/3y/swkjq1x101b76mzjgt4pm2d80000gp/T/xfs-2ac5acc4/yarn
    npm: 10.1.0 - /usr/local/bin/npm
    bun: 1.0.12 - ~/.bun/bin/bun
  Browsers:
    Chrome: 119.0.6045.199
    Edge: 119.0.2151.97
    Safari: 17.1

Used Package Manager

yarn

Validations

@wojtekmaj wojtekmaj changed the title [v1.0.1] Unnecessary (?) check for if vite is installed Unnecessary (?) check for if vite is installed Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant