Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3905] default url when using happy-dom as environment #3907

Closed

Conversation

capricorn86
Copy link
Contributor

Description

Sets the default page URL for Happy DOM to the same URL as JSDOM.

Closes #3905

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Aug 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 7ac694c
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64d1427abe9f9400087cbb36

@userquin
Copy link
Member

userquin commented Aug 7, 2023

why not just allow provide all happy-dom options? check my suggestion in #3902

@capricorn86
Copy link
Contributor Author

why not just allow provide all happy-dom options? check my suggestion in #3902

I agree @userquin! If that PR is approved it is better if we support both.

@capricorn86
Copy link
Contributor Author

I'm closing this PR in favor of #3902 that has added the default URL to it.

@capricorn86 capricorn86 closed this Aug 9, 2023
@capricorn86 capricorn86 deleted the 3905-default-happy-dom-url branch September 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default URL when using Happy DOM as environment
2 participants