Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show assertion/expect failures inline on the line that actually failed #37

Closed
beorn opened this issue May 20, 2022 · 1 comment
Closed

Show assertion/expect failures inline on the line that actually failed #37

beorn opened this issue May 20, 2022 · 1 comment
Assignees
@zxch3n
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@beorn
Copy link

beorn commented May 20, 2022

Currently test results are shown for the entire test as a whole, which for tests that have several expects makes it hard to figure out what actually failed.

It would be better, IMO, to show the failure where it actually happened in the context of the source code, such as is done with Jest Test Explorer or the terminal runner for vitest - see screenshots.

Current output

Screen Shot 2022-05-20 at 09 51 55

Better - Vitest terminal output

Screen Shot 2022-05-20 at 09 49 38

Best - Jest explorer - inlined with source code

Screen Shot 2022-05-20 at 09 47 15
@beorn beorn added the p2-nice-to-have Not breaking anything but nice to have (priority) label May 20, 2022
@zxch3n zxch3n self-assigned this May 23, 2022
zxch3n added a commit that referenced this issue May 23, 2022
@zxch3n
feat: show error on the line it failed in watch mode #37
793e2fc
@zxch3n zxch3n mentioned this issue May 23, 2022
Closed
@zxch3n
Copy link
Member

zxch3n commented Jun 18, 2022

It's supported in the pre-release version now

@zxch3n zxch3n closed this as completed Jun 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zxch3n zxch3n

Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beorn @zxch3n