add distinct type for cache paths #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, a 'naked' file or dir path would be treated like a cache when passed to a thunk. this was a bit hastily slapped together and it was never really obvious behavior. if anything folks would likely do this trying to mount a host path in, and have it do _something_, but not what they expect. now cache paths are a distinct path type constructed like so: (cache-dir "foo") where "foo" is an explicit identifier for the cache dir. rather than using the path itself as the cache key, the user provides one for the root. this means you can now pass a subdirectory of a cache dir to a thunk if you want - previously that would yield an entirely different cache key. you can also use a cache path as a thunk command now, because why not.
vito
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, a 'naked' file or dir path would be treated like a cache when passed to a thunk as a mount source. this was a bit hastily slapped together and it was never really obvious behavior. if anything folks would likely do this trying to mount a host path in, and have it do something, but not what they expect.
now cache paths are a distinct path type constructed like so:
where "foo" is an explicit identifier for the cache dir. rather than using the path itself as the cache key, the user provides one for the root. this means you can now pass a subdirectory of a cache dir to a thunk if you want - previously that would yield an entirely different cache key.
you can also use a cache path as a thunk command now, because why not.