auto-start buildkitd in Docker if not configured
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this complexity is no longer necessary now that you can just forward a runtime service over gRPC Revert "refactor buildkit addr defaults into runtime pkg" This reverts commit 5d27026. Revert "resolve defaults in main rather than runtime init" This reverts commit 50e0fad. Revert "simplify RuntimeAddrs" This reverts commit 151e72d. Revert "add SetService helper" This reverts commit 7c63a99. Revert "give addrs a distinct section in runtime config" This reverts commit c888a43. Revert "use buildkit runtime defaults in tests" This reverts commit 8b7a0d1.
this should make getting started _much_ easier - you don't need to manually set up a Buildkitd daemon, it just runs the matching version in Docker. original license (Apache) and notice preserved.
this should be made configurable and op-in someday
vito
changed the title
buildkitd in Docker if not configured
no more manual buildkit setup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it much much easier to get started with Bass; just install Docker and it'll run its own Buildkit daemon if you don't have one configured.
This is based on Dagger's
util/buildkitd. 🙏Original license and copyright notice preserved.