introduce Custodians, refactor (read), add (assert)
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it easier to just move test assertions into test scripts instead of having them "return" something, which isn't always possible (e.g. when testing Sessions)
(read) no longer buffers the entire stream. instead, PipeSource is now Close()able and any opened source is registered with a Custodian for cleaning up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(read)no longer buffers the entire stream. instead,PipeSourceis nowClose()able and any opened source is registered with aCustodianfor cleaning up.Note that there isn't actually a
(close)at this point since I'm not sure if people will even need to care about that level of detail. Would rather not have people feel the need to resource manage so carefully. Right now everything is closed automatically when a script runs or is loaded. We'll see if we need anything more than that.