use Buildkit's new OCI stores feature for image archives #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vito
commented
Dec 26, 2022
vito
commented
- remove image unpack/get-config calls from shim (yay!)
- maintain an OCI content.Store in $XDG_DATA_HOME/bass
- use containerd's new transfer code to import an OCI tar stream into it
* remove image unpack/get-config calls from shim (yay!) * maintain an OCI content.Store in $XDG_DATA_HOME/bass * use containerd's new transfer code to import an OCI tar stream into it
this is helpful for testing local buildkit image changes without having to push.
now that we call ThunkPath.Open in the runtime we need to have a Pool available. this is getting ... has long been a bit janky jank, but that's a refactor for another day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.