Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing guest molecules in sH structure #4

Closed
eszter137 opened this issue Mar 24, 2020 · 5 comments
Closed

Missing guest molecules in sH structure #4

eszter137 opened this issue Mar 24, 2020 · 5 comments

Comments

@eszter137
Copy link

Hi,

it seems the sH clathrate structure doesn't include the cages information in genice/lattices/sH.py so it won't have guest molecules in the generated structure.
(This was my command line:
genice --rep 2 2 2 --seed 0 --format=exyz --water tip3p -g 12=ch4 sH)

I was wondering if the information for the cages could be added.

Many thanks,
Eszter

@vitroid
Copy link
Owner

vitroid commented Mar 25, 2020

Thank you very much for your report.

sH.py has been updated to include cage information in the develop branch, but it was not reflected in the master. The new sH.py is now included in the latest GenIce. Update it with the pip command.

@vitroid vitroid closed this as completed Mar 25, 2020
@eszter137
Copy link
Author

Thank you very much!
Sorry, it is strange but it seems there might have been a problem with the commit: the page https://github.com/vitroid/GenIce/tree/master/genice/lattices shows that it is the DOH.py that changed 4 hours ago with the commit and the latest change for sH.py was 3 years ago.

@vitroid
Copy link
Owner

vitroid commented Mar 25, 2020

It is ok. sH.py is actually a link file (aka alias) to DOH.py. The name "DOH" comes from the Zeolite database. The structures of clathrate hydrate type H and zeolite DOH are topologically identical.

@vitroid
Copy link
Owner

vitroid commented Mar 25, 2020

@eszter137
Copy link
Author

Apologies, it was me messing up - it seems I had 2 versions of genice (because of having one pip in the conda environment and one outside) and it seems I updated the one that was not the default for the genice command. Now I uninstalled the other one and it works fine.
Thank you very much again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants