Feature/disable jobs via api #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces the functionality to disable certain jobs for specific manufacturers. The feature includes addition of a new 'DisabledJob' class to facilitate this. Methods to disable a job and to check whether a job is disabled for a given manufacturer have been added to the 'ApplicationData' and 'ApplicationDataRepository' classes.
The DataImportScheduler constructor has been streamlined by using Lombok's @requiredargsconstructor annotation. Further, the job checking function in ApplicationDataRepository has been switched from 'isTheJobDisabled' to 'isTheJobEnabled' to improve code readability. Now, the data import job is only initiated if it's enabled both by the application configuration and the job checking function.
The ApplicationData class has been updated to include the manufacturer in the DisabledJob object. This new property will be set whenever a job is disabled. This addition will enable the distinguishing of jobs based on manufacturers.
A new endpoint '/job' has been introduced in BaseMappings. JobController class is added to manage job-related operations. Additionally, added a new DTO - DisableJobRequest, representing a request to disable a job, which includes manufacturer details. This will allow disabling jobs for a specific manufacturer.
This update adds a new endpoint '/v1/job' to the OpenAPI specification, specifically to include a 'patch' operation that disables a job for a manufacturer. It also introduces a 'DisableJobRequest' schema that outlines the structure of the request body for this operation, including necessary manufacturer details.
Vitrum-LL
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111