Feature/fallback to generic device creation in case the sensor is not found #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored SentekFiwareIntegrationServiceWrapper to include manufacturer-specific ID and location in the device builder, and added some additional methods to persist and retrieve those data. Updated the version of fiware-integration-layer in pom.xml to 6.2.0. In DeviceMeasurementController, added logic to search for generic sensors if none are found within the sentek catalog. Finally, added manufacturerSpecificId field in GenericDeviceIntegrationService. These changes improve device measurements' reliability by persisting additional data and allowing for more robust error handling.
The persistence method in AgvolutionFiwareIntegrationServiceWrapper was refactored to also utilize latitude and longitude data from a series entry, providing spatial context. The deviceIdOf method was added for easy device ID retrieval. "No sensor found" message in DeviceMeasurementController now covers a more general case. Additionally, annotation was added to TimeSeriesEntry, TimeSeriesValue, and SeriesEntry models to improve API endpoints' documentation. These changes provide richer device details during persistence and enhance API usability via detailed endpoint descriptions.
…f commit message. Please consider shortening your answer.
Updated the version number of our api in the pom.xml file. This update is following our new feature addition that necessitated a version bump from 10.0.0 to 10.1.0.
Vitrum-LL
approved these changes
Nov 3, 2023
saschadoemer
deleted the
feature/fallback-to-generic-device-creation-in-case-the-sensor-is-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97