Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs number compare final #20

Merged
merged 3 commits into from
Mar 22, 2018
Merged

Vs number compare final #20

merged 3 commits into from
Mar 22, 2018

Conversation

devtanc
Copy link
Member

@devtanc devtanc commented Mar 22, 2018

Checklist

  • Atomic commits
  • Tests adjusted to address changes
  • Documentation
  • Storybook adjusted to reflect changes (if applicable)
  • Reviewed by author
  • Ready for review

fix: Update readme
fix: Linter fixes
fix: Separate out components for simplicity
fix: Update storyboard implementation
@devtanc
Copy link
Member Author

devtanc commented Mar 22, 2018

<View style={ [ styles.wrapper, styles.contrast ] }>
<VSNumberCompare.Wrapper
data={ values2 }
// style={ { backgroundColor: 'transparent' } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be removed

@devtanc devtanc merged commit 66bd33d into master Mar 22, 2018
@devtanc devtanc deleted the VSNumberCompare-final branch March 22, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants