Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(InfoFIllICon): add stroke and fill to props #34

Merged
merged 1 commit into from
May 31, 2018
Merged

feature(InfoFIllICon): add stroke and fill to props #34

merged 1 commit into from
May 31, 2018

Conversation

CameronEldonGale
Copy link
Member

@CameronEldonGale CameronEldonGale commented May 31, 2018 •
edited
Loading

Checklist

  • Atomic commits
  • Tests adjusted to address changes
  • Documentation
  • Storybook demo adjusted to reflect changes (if applicable)
  • Snack demo adjusted to reflect changes (if applicable)
  • Reviewed by author
  • Ready for review

@zack37 zack37 removed the request for review from EpicButterz May 31, 2018 19:15
zack37
zack37 requested changes May 31, 2018
View reviewed changes
packages/VSSvg/InfoFillIcon.js Outdated
@@ -1,19 +1,20 @@
import React, { Component } from 'react';
import { Component } from 'react';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to leave React in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Why?

@CameronEldonGale CameronEldonGale merged commit 2faf6af into master May 31, 2018
@CameronEldonGale CameronEldonGale deleted the infoIcon branch May 31, 2018 19:29
@tcasey
Copy link
Contributor

tcasey commented May 31, 2018 •
edited
Loading

@CameronEldonGale You'll just want to make sure that you version it correctly when you release since it's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heracliorios heracliorios heracliorios approved these changes

@zack37 zack37 zack37 approved these changes

@devtanc devtanc Awaiting requested review from devtanc devtanc is a code owner

@tcasey tcasey Awaiting requested review from tcasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CameronEldonGale @tcasey @zack37 @heracliorios