Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TinyMCE for fixed html pages #454

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Mar 26, 2024

VIVO GitHub issue
VIVO PR

What does this pull request do?

Enables TinyMCE editor for Fixed HTML field.

How should this be tested?

  • Create/Edit Fixed html pages, check result

Additional information

Stacked on top of #452

Interested parties

@VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks for this contribution.

This is working only in the isolated Vitro instance.
There is a pageManagement--customDataScript.ftl in VIVO, please apply the similar changes there.

chenejac
chenejac previously approved these changes Apr 11, 2024
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg I have tested this, it is working as expected. I have posted one comment in the VIVO PR, but it will be resolved in the separate PR. I have review the code only of the second commit, and don't have any suggestion for improvement.

@chenejac chenejac requested a review from milospp April 12, 2024 11:03
@milospp
Copy link
Contributor

milospp commented May 13, 2024

@litvinovg When I create a new fixed HTML content I see a basic text editor until I save and refresh the page, only then (when editing) rich text editor is shown.

image

@litvinovg
Copy link
Contributor Author

@milospp I added fixes for the issue. Could you test it once again?

@litvinovg litvinovg removed the stacked label Sep 16, 2024
@milospp
Copy link
Contributor

milospp commented Sep 24, 2024

@milospp I added fixes for the issue. Could you test it once again?

I tested and it works fine

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg works for me

@chenejac chenejac merged commit 3e7b913 into vivo-project:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed html pages editing should be supported with WYSYWIG editor
3 participants