-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TinyMCE for fixed html pages #454
Enable TinyMCE for fixed html pages #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg thanks for this contribution.
This is working only in the isolated Vitro instance.
There is a pageManagement--customDataScript.ftl in VIVO, please apply the similar changes there.
9e9e18c
to
499a21c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg I have tested this, it is working as expected. I have posted one comment in the VIVO PR, but it will be resolved in the separate PR. I have review the code only of the second commit, and don't have any suggestion for improvement.
@litvinovg When I create a new fixed HTML content I see a basic text editor until I save and refresh the page, only then (when editing) rich text editor is shown. |
499a21c
to
5826b6e
Compare
@milospp I added fixes for the issue. Could you test it once again? |
I tested and it works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg works for me
VIVO GitHub issue
VIVO PR
What does this pull request do?
Enables TinyMCE editor for Fixed HTML field.
How should this be tested?
Additional information
Stacked on top of #452
Interested parties
@VIVO-project/vivo-committers