支持motan rpc框架 #46
Merged
支持motan rpc框架 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coderDylan
commented
Aug 8, 2023
coderDylan
commented
- Added support for motan rpc framework
- Fixed several bugs
2.解决motan插件子调用时mock的问题
2.修复motan provider端返回值获取的bug
2.兼容接口方法有重载的情况
|
我看是不是把个人数据库账号密码提交上来了？需要删除吗 |
那个我应该已经脱敏过了的，都是本地测试的环境，风险还好 |
|
@yananliuyanjiang 抽空帮忙review一下 |
|
OK |
node
reviewed
Aug 17, 2023
| @@ -249,6 +250,7 @@ public boolean saveData(RecordWrapperEntity wrapper) { | |||
| entity.setResponse(wrapper.getResponse()); | |||
|
|
|||
| try { | |||
| //TODO 这里会莫名奇妙的把response字段转义 | |||
There was a problem hiding this comment.
这个地方是这样的，如果RPC接口方法响应结果是纯字符串类型的，会自动给加上转义字符。当然，通常一般公司定义RPC接口方法返回类型都会是定义的POJO包装类型，不会直接返回一个String。
这个转义字符，会导致在结果对比的时候对比是通过的，但是diff界面上会出现不一致提示，视觉上有点影响。这个转义字符的问题，我在其他地方做了特殊处理，已经解决了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.