feat: normal match repeated pattern #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
main (baseline) bugfix iterator copied |
TroyKomodo
force-pushed
the
troy/fix-dot-find
branch
from
914f9a8
to
0f173ea
Compare
This commit adds a feature which allows the normal matcher to match paths like `/:file.gz` or `/:lib.js.gz` Previously this would have found no routes on paths like `/node.js.gz` Now `/:file.gz` matches `/node.js.gz` where "name" => "node.js" And `/:lib.js.gz` matches `/node.js.gz` where "lib" => "node" Which to me seems like the correct result in these cases. fixes: viz-rs#36
TroyKomodo
force-pushed
the
troy/fix-dot-find
branch
from
0f173ea
to
bed678c
Compare
TroyKomodo
added a commit
to ScuffleTV/scuffle
that referenced
this pull request
Jan 1, 2024
Fixed a bug in path-tree viz-rs/path-tree#37
|
Landed in v0.7.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #36