Improve performance of parallel operations #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the main service mutex with two read write mutexes to improve the speed of parallel operations on already compiled expressions. All critical sections have been reduced to the bare minimum. This leads to a performance improvement of ~250% on parallel operations.
I added a new benchmark to be able to compare the speed and validity of parallel operations.
The results are as follows:
Please note that no mutexes would be required if further API changes would be introduced to this library:
We created a fork that does exactly this but IMO contains too many other changes to be merged back to this repository. If you are interested, please see https://github.com/trivago/grok.