Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View unsaved document #1884

Closed
awqk opened this issue May 21, 2024 · 4 comments · Fixed by #1902
Closed

View unsaved document #1884

awqk opened this issue May 21, 2024 · 4 comments · Fixed by #1902
Labels
editor Component: Editor enhancement Request: New feature or improvement next release Note: Features planned for next release

Comments

@awqk
Copy link

awqk commented May 21, 2024

Opening a view to an unsaved document doesn't show latest changes, see also #1835.

@vkbo
Copy link
Owner

vkbo commented May 21, 2024

Since the viewer isn't intended as a preview, it does not automatically update with the editor if displaying the same document. However, if you do look at the same document, it is assumed you are doing this so you can see the difference between what you're editing and what it was before. If you press Ctrl+R in the editor, it will update.

This is intentional, and not a bug or missing feature.

@vkbo vkbo closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@vkbo
Copy link
Owner

vkbo commented May 21, 2024

On second thought, maybe I misunderstood this request? If so, please clarify and I'll reopen if still relevant.

@awqk
Copy link
Author

awqk commented May 21, 2024

Since the viewer isn't intended as a preview, it does not automatically update with the editor if displaying the same document. However, if you do look at the same document, it is assumed you are doing this so you can see the difference between what you're editing and what it was before. If you press Ctrl+R in the editor, it will update.

I am thinking this might be a bit of hit-and-miss. When opening, you don't know if auto-save has already overwritten the earlier version you may want to view, therefore, nw should display the latest version. Once the view panel is open, it shouldn't update automatically, as you said.

@vkbo vkbo reopened this May 22, 2024
@vkbo
Copy link
Owner

vkbo commented May 23, 2024

I reopened this as requested. I'll add a check that saves the editor before opening the same document in the viewer, but only in this specific case.

@vkbo vkbo added this to the Release 2.5 Beta 1 milestone May 23, 2024
@vkbo vkbo added enhancement Request: New feature or improvement editor Component: Editor labels May 23, 2024
@vkbo vkbo added the next release Note: Features planned for next release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Component: Editor enhancement Request: New feature or improvement next release Note: Features planned for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants