Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global search #1936

Merged
merged 4 commits into from
Jun 16, 2024
Merged

Update global search #1936

merged 4 commits into from
Jun 16, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 16, 2024

Summary:

This PR:

  • Cleans up some save document code in the Shared class, also used by Search.
  • Adds a call to refresh the search when changing search options.
  • Changes how the search context is generated to include the whole word the search result was found in.

Related Issue(s):

Closes #1830

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 16, 2024
@vkbo vkbo merged commit 45ad0f8 into main Jun 16, 2024
8 checks passed
@vkbo vkbo deleted the update_search branch June 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Search Enhancements
1 participant