Fix top-level BVH implementation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkoskiv
approved these changes
Jun 17, 2020
vkoskiv
added a commit
that referenced
this pull request
Jun 17, 2020
* Start work on an experimental top-level BVH + traversal. It's disabled for now, switch the implementations in getClosestIsect() Still some issues to work out, but it's something. I don't really like the meshIndex hack I had to add to the polygon struct, but I gues it's not that bad since I managed to shrink it anyway. * Maybe MSVC dislikes compound literals, let's try getting rid of those here. * Make bvh construction truly generic to limit code duplication (#78) * Make bvh construction truly generic * Spaces -> tabs * Update .xcodeproj to reflect changes in pull request 78 * Hide `struct bvhNode` and `struct bvh` and present them as opaque structs in the API instead. * Continue implementing generic BVH traversal * Rename rayIntersectsWithGenericBvh -> rayIntersectsWithBvhGeneric Fix incorrect function call in rayIntersectsWithBvh() * Rename `rayIntersectsWith*` -> `traverse*` * Fix naming Add inline qualifiers to a few functions. * Fix top-level BVH implementation (#79) * Fix top-level BVH implementation * Minor performance improvements to the BVH traversal * Remove redundant assignment * Move address offset inside indirect access Co-authored-by: Arsène Pérard-Gayot <arsene.perard@laposte.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the top-level BVH implementation and enables it during rendering. A couple of additional notes:
meshIndexandpolyIndexout of thepolystructure. Just add ameshIndexto thehitRecordand let the BVH set it when it iterates over the meshes contained in a top-level leaf. The same can be said for the bottom-level leaves and thepolyIndexmember.