Implement optree transformation: Join identical conditional branches #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksimShagov
commented
May 20, 2024
| auto ifOp = op->as<IfOp>(); | ||
| if (auto elseOp = ifOp.elseOp()) { | ||
| auto thenOp = ifOp.thenOp(); | ||
| if (elseOp->body.size() == thenOp->body.size()) { |
There was a problem hiding this comment.
Вроде бы можно просто функцию сверху заколить через ренж
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
compiler/lib/backend/optree/optimizer/transforms/join_conditions_branches.cpp
Fixed
Show fixed
Hide fixed
vla5924
requested changes
May 25, 2024
| static inline bool compareOperations(const Operation::Ptr &lhs, const Operation::Ptr &rhs) { | ||
| auto attrEqual = [](const Attribute &lhs, const Attribute &rhs) { return lhs.storage == rhs.storage; }; | ||
| bool attr = std::ranges::equal(lhs->attributes, rhs->attributes, attrEqual); | ||
| auto valueEqual = [](const Value::Ptr &lhs, const Value::Ptr &rhs) { return lhs->type == rhs->type; }; |
There was a problem hiding this comment.
Это неправильное сравнение. Например, два таких body по твоей логике будут одинаковые, хотя value 0 и 1 используются по разному:
Op1 (...) -> (#0: float)
Op2 (...) -> (#1: float)
Op3 (#0, #1) -> (...)
---
Op1 (...) -> (#0: float)
Op2 (...) -> (#1: float)
Op3 (#1, #0) -> (...)И более простой случай (если 0 и 1 созданы где-то снаружи):
Op1 (#0: float, #1: float) -> (...)
---
Op1 (#1: float, #0: float) -> (...)А еще у операций есть specId и name, которые тоже должны совпадать. Надо бы вынести все это в отдельную функцию в helpers, по идее #179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.